greencatsoft / scalajs-angular

AngularJS Binding for Scala.js
Apache License 2.0
252 stars 42 forks source link

Add injector reference and facade to Angular #69

Closed easel closed 8 years ago

easel commented 8 years ago

This is a very very basic facade for the "Injector" class in Angular.

mysticfall commented 8 years ago

Thanks much for the contribution again! I made minor suggestions above, so please let me know what you think about them.

easel commented 8 years ago

Ok I've made both your suggested changes, but my build is failing on the docs when I try to compile the code rebased against master, so I haven't confirmed my concern about the missing () to be unfounded.

Not sure what's going on there yet.

mysticfall commented 8 years ago

I just did a quick test and I didn't find the compile problem you mentioned, but you were right that the facade method should contain parentheses.

I'll modify the commit and merge the PR. Thanks much for the contribution! :)

mysticfall commented 8 years ago

It seems the PR remains unmerged if I manually squash and merge the branch. I'll just close this, as I can the commit is merged into the master with the correct authorship.

easel commented 8 years ago

Great, thanks!