greendoescode / vlc-rpc

Discord rich presence for VLC media player. This is a fork of PigPogs VLC RPC, adding automatic album art.
MIT License
15 stars 3 forks source link

Option for custom URL for image in RPC. #17

Closed MattTheTekie closed 11 months ago

MattTheTekie commented 1 year ago

Can you add option in the config file for a custom image URL?

sdasda7777 commented 1 year ago

I think I have a pretty good idea how to do that, I'll look into it unless @GreenDiscord would like to do it himself.

greendoescode commented 1 year ago

Could you please giveme the problem your having with album art, What has made you like custom urls?

MattTheTekie commented 1 year ago

It's not an issue, it's a feature request

greendoescode commented 1 year ago

Oh, Ok.

greendoescode commented 1 year ago

Pinned as a reminder

sdasda7777 commented 11 months ago

I think I found an example where this feature would be help: Metal Gear Rising OST. Not sure what the exact reason is, but neither library is able to find the cover. Possibly the fact both Spotify and Apple Music list the album artist as "Various Artists" doesn't help, the fact only vocalist is listed as the song artist there might be a second issue.

image

image

greendoescode commented 11 months ago

Ok that makes sense.. I'm just thinking about any issues this may cause. It should work though.

sdasda7777 commented 11 months ago

I'll look into this once the Youtube thing gets sorted out. Also funnily enough, this is once instance where it really goes over the 128 character Discord state limit 😂

sdasda7777 commented 11 months ago

Slight issue arises, where the user should choose the "musichoarders" provider to for the best experience, but also something like "static-overrides" to use overrides.

I think there should be a more robust solution to this, but it does appear that JS objects are required to follow order of insertion when iterating, meaning Object.keys({a: "c", b:"d"}) evaluates to ['a', 'b'] and Object.keys({b:"d", a: "c"}) evaluates to ['b', 'a']. That could be leveraged to define fetching order as {"static-overrides": ..., "musichoarders": ..., others}. Of course, there currently isn't a way to give user more control over this, other than the initial provider that will be tried.

MattTheTekie commented 11 months ago

I'm glad to see this thread continuing. 😊