greendoescode / vlc-rpc

Discord rich presence for VLC media player. This is a fork of PigPogs VLC RPC, adding automatic album art.
MIT License
15 stars 3 forks source link

Restructured fetching logic to make it clearer #21

Closed sdasda7777 closed 11 months ago

sdasda7777 commented 11 months ago

The restructuring not only makes it easier to debug and extend, but also fixes #20 due to not calling the Youtube library unless explicitly desired by the user.

sdasda7777 commented 11 months ago

@GreenDiscord Hi, could you take a look at this please? 😄

greendoescode commented 11 months ago

For sure, as always, is it tested to be working?

sdasda7777 commented 11 months ago

It works for me, but I honestly still don't understand some parts of the program, so I might be missing something that I just didn't think to test 😅 It also doesn't check Spotify as a backup in case Apple failed to find anything anymore, but I think that was sort of misleading to do anyways 😅

sdasda7777 commented 11 months ago

Actually, it might be good idea to ask @Choomai if it solves their issue before merging 😅

greendoescode commented 11 months ago

It works for me, but I honestly still don't understand some parts of the program, so I might be missing something that I just didn't think to test 😅 It also doesn't check Spotify as a backup in case Apple failed to find anything anymore, but I think that was sort of misleading to do anyways 😅

Only reason I had the option to choose is if spotify had different album work vice versa.

sdasda7777 commented 11 months ago

Ah, I see, that makes sense 😅 I'll look into how to best keep the functionality, then 😅

sdasda7777 commented 11 months ago

@GreenDiscord Now it should be checking other sources if the preferred ones fail. I also added try-catch-finally around the Youtube fetching code, so now it won't crash anymore, just print the error. By the way, would you happen to know what the error @Choomai is getting (it's posted at #20) might mean? 😅

sdasda7777 commented 11 months ago

@GreenDiscord It appears to be working as intended with this last commit. Do you have any concerns about the new code? 😄

greendoescode commented 11 months ago

This all good now?