greendoescode / vlc-rpc

Discord rich presence for VLC media player. This is a fork of PigPogs VLC RPC, adding automatic album art.
MIT License
16 stars 3 forks source link

Restore Pigpog's commits #7

Closed sdasda7777 closed 1 year ago

sdasda7777 commented 1 year ago

Hey, it appears that there are no commits from Pigpog or dylhack in this repo, which doesn't make sense, since it is a fork of a repo they contributed on. I believe that sort of steals the ownership of the code from them, and clearly is violation of the license they provided their code under.

Please try to restore the old commits. If there is ~100 commits by you here now and ~200 commits by them in the old repo, there should be ~300 commits in this repo.

greendoescode commented 1 year ago

Dylhack knows about this and pigpog does, neither have raised any issues. I have credited PigPog in the readme and now the description. I cannot though add their commits back.

sdasda7777 commented 1 year ago

May be, but it is still wrong. You should be able to add their commits just fine, just clone the old repo and rebase this one onto it, then push it here.

greendoescode commented 1 year ago

To add, i have added them to the license, which it should've been from the start, github just overwrited it.

sdasda7777 commented 1 year ago

You should be able to add their commits just fine, just clone the old repo and rebase this one onto it, then push it here.

Do note, though, that rewriting history is one of the more dangerous git operations, so if you were to do this, you should triple check everything went right before pushing here 😅

greendoescode commented 1 year ago

Yeah thats why I'm hestitant. I'll have a look, ty