greenelab / adage-frontend

The Adage web app, a tool to explore gene expression data and discover new insights from machine learning models
https://adage.greenelab.com
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Searching with lists #178

Closed debhogan-208 closed 4 years ago

debhogan-208 commented 4 years ago

On two browsers (Chrome and Safari), searching with a list of 14 genes gave two to four identical returns (the links suggested they were the same). They weren't always contiguous but they all highlighted when you clicked one.

Screenshot 2020-05-03 09 09 50 Screenshot 2020-05-03 09 11 01
vincerubinetti commented 4 years ago

This is behaving as intended. Searches on the backend might return the same set of results for two similar search strings. Then, if you click to select one gene, if that same gene shows up in a different search result, the checkmark status will be the same, because it's the same gene. If that gene is selected, it should show a checkmark to indicate to the user that it's selected, and that clicking it will unselect it.

In other words, what genes are selected is global to the whole app, not local to each search string in the multi search.

If you believe that two different search strings should be returning significantly different results, we'll have to talk to @dongbohu about tweaking the search weights and etc.

dongbohu commented 4 years ago

When searching a list of genes, it may make more sense to do exactly match (case-insensitive) on each one (instead of fuzzy match).

cgreene commented 4 years ago

I like @dongbohu's idea. If the match scores are directly comparable between search terms, you could also only display a potential match as an option in the cases where it had the highest score. However, this would require that scores be comparable b/w queries.

vincerubinetti commented 4 years ago

I implemented this a while ago and haven't received confirmation that it's okay. But it stands to reason (imo) that if you're searching for a list of genes, you'll want more exact matches, so the fix makes sense to me. Closing for now.