search

greenelab / connectivity-search-frontend

Frontend code for connectivity search (formerly "Hetmech")
https://het.io/search
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

add deselect/select all filter buttons, make filter buttons draggable #143

Closed vincerubinetti closed 5 years ago

vincerubinetti commented 5 years ago

image

@dongbohu this pr moves the filter buttons to their own component in filters.js for simplicity, and adds functionality to drag to select and also adds the two buttons at the top for deselect/select all.

dhimmel commented 5 years ago

adds the two buttons at the top for deselect/select all

I like the appearance of the implementation! They are small and separated as to not get confused with node types, while still being visible and close-by.

The only other question I've been thinking about is whether we should reset filters after the user selects a node, but I'm currently leaning against that. The benefit would be for users who want to select different node types, but it may be a bit confusing and problematic for users who are cycling through many nodes of the same type.