search

greenelab / connectivity-search-frontend

Frontend code for connectivity search (formerly "Hetmech")
https://het.io/search
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

tooltips for filters? #16

Closed vincerubinetti closed 5 years ago

vincerubinetti commented 5 years ago

Might be nice to have tooltip text for the metatype filters. Maybe they're too basic (eg Gene) to warrant tooltips, but we have them for everything else.

Edit: and source/target node

vincerubinetti commented 5 years ago

Done. Will include in upcoming PR of small changes/additions.

dhimmel commented 5 years ago

We haven't made concise definitions for metanodes / metaedges yet. I agree they will be useful, although perhaps a bit challenging to construct. We should look at what is available in the Rephetio Manuscript Methods and go from there.

vincerubinetti commented 5 years ago

I understand the difficulty. We also don't have to get it perfect right away. They can be changed easily in the future, of course. For now, I think if we get a general "rough feeling" definition for them, just so the user has some explanation, that would be fine. The rest of the tooltips are just an introductory explanation, and would require further reading for true understanding anyway.

dhimmel commented 5 years ago

Well I think a "rough feeling" if inaccurate could be worse than nothing. But since I think we should have definitions for these terms, I'm happy to take the time with you now to create a pretty good set of definitions.

dhimmel commented 5 years ago

On further thought, let's make a definitions.json file in the hetionet repo.

describe/definitions.json could be an appropriate location.

dhimmel commented 5 years ago

Looks like this was fixed in https://github.com/greenelab/hetmech-frontend/commit/2c23a4d4f0bb4ad78c8f5d3d0a528fe65e358c9c?