Closed dhimmel closed 1 year ago
I think the changes in your slides look good. Best way to match the aesthetic is to use the same font, Lato, which it looks like you have, and to use the same colors where possible.
compound-disease pairs can use connectivity search background highlights. Like image but the edge has no label because these are just endpoints.
I think that's a nice idea. You could also put a nice . . .
in between.
remove status column if treatment/non-treatment is clear from other visual element
I think the "treatments" box you've added is a much clearer and nicer way to indicate the status than the status column, and i think you could remove it.
If you've already implemented some changes in your slides.com presentation, do you just want to continue the changes there? Can it export as svg? I know a lot of people in the lab have made figures via powerpoint. Otherwise, can you zoom in and scale up the slide.com figure enough to make a really high resolution raster image?
I could also edit the original matplotlib in inkscape to re-add your changes. Or make it look super pretty and do it by hand. But those would take time.
I could probably make the figure by continuing with slides.com. would copy the slide and remake with a white background for the manuscript.
I probably wouldn't be able to do background color for compound–disease labels. Matplotlib will struggle doing anything fancy with the labels. So to change them I'd just cover them in slides.
How much time would it take for you to do it via the SVG / illustrator? If you think it'd be most efficient for me to do the additional tweaks in slides, I can do that
On Mon, Jun 22, 2020, 11:10 PM Vincent Rubinetti notifications@github.com wrote:
I think the changes in your slides look good. Best way to match the aesthetic is to use the same font, Lato, which it looks like you have, and to use the same colors where possible.
compound-disease pairs can use connectivity search background highlights. Like image but the edge has no label because these are just endpoints.
I think that's a nice idea. You could also put a nice . . . in between.
remove status column if treatment/non-treatment is clear from other visual element
I think the "treatments" box you've added is a much clearer and nicer way to indicate the status than the status column, and i think you could remove it.
If you've already implemented some changes in your slides.com presentation, do you just want to continue the changes there? Can it export as svg? I know a lot of people in the lab have made figures via powerpoint. Otherwise, can you zoom in and scale up the slide.com figure enough to make a really high resolution raster image?
I could also edit the original matplotlib in inkscape to re-add your changes. Or make it look super pretty and do it by hand. But those would take time.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/greenelab/connectivity-search-manuscript/issues/11#issuecomment-647880628, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIQ4B72Y6QP6RYRGPYJSNDRYAMJ7ANCNFSM4OEY4XKQ .
Overall it'd be faster for you to do it, but i could do it a bit more cleanly with inkscape or manually. Also I have more free time right now that you do. So I'll do it.
@dhimmel Ready for proof read
Ready for proof read
A true masterpiece!
It displays properly for me in Chrome, but not Inkscape or my desktop viewer (the x-axis metapath labels don't render properly). So we should also export a high-rez PNG (like 300 dpi?) as a backup.
Also would it be possible to create a version where the new metagraph is on the left and this figure is on the right, with AB labels?
Transparent raster version:
The SVG version uses advanced svg features that wont render properly in inkscape, online converters, word documents, etc. So only use the SVG version if you're sure it's going to be viewed in a modern browser like Firefox or Chrome.
Ah found a typo in the final metapath
For future reference, I'm using https://vincerubinetti.github.io/svg-to-png/ to save it as a high resolution png.
Updated to fix typo, and to include version for black backgrounds.
Updated to fix typo, and to include version for black backgrounds.
Awesome. The dark background version will be great for presentations!
Linking to the notebook on Google Collab we used to change the diverging colormap colors for the heatmap. It was based on the rephetio notebook 8-feature-example-viz.ipynb
.
Also would it be possible to create a version where the new metagraph is on the left and this figure is on the right, with AB labels?
How's this:
How's this:
Nice. You can see it in the manuscript here.
FYI i mentioned earlier that we want minimal margins. I think I should amend my comment that we still want some margin, like 2-5 pixels. Although as I look at journal guidelines, I'm not actually sure. Some seem to want zero margins. @cgreene in your experience, do we want a small margin or no margin at all?
For the manubot view, 2-5 pixel margins would be nice for fullscreen view:
But otherwise are not needed.
I have no idea!
@dhimmel For your screenshot, perhaps it's a better idea to add margins to the lightbox plugin itself.
For your screenshot, perhaps it's a better idea to add margins to the lightbox plugin itself.
Would it be possible to to detect the margin from a property like:
![](){#fig:id width="100%" lightbox-margin="5px" .white}
What syntax would you recommend?
Let's get a new issue for that. I'm not sure having an extra property is the right way to do it.
Currently the manuscript has the following figure and caption for the project rephetio ML approach:
I think we can make this fit the connectivity search aesthetic a bit better. I've made some improvements at https://slides.com/dhimmel/rocky2019#/11/1/3:
The additions are as follows:
other ideas:
The SVG source is available here. @vincerubinetti how doable do you think these changes are?
Also thinking of making this a 1x2 figure where A is the new metagraph with new node colors created for connectivity search (after https://github.com/hetio/het.io/issues/36 is fixed). B would be the rephetio feature heatmap above.