search

greenelab / library-access

Collecting data on whether library access to scholarly literature
Other
5 stars 3 forks source link

Enable Travis CI for testing #9

Closed dhimmel closed 7 years ago

dhimmel commented 7 years ago

@publicus can you review this.

The purpose is to use TravisCI to automate the testing. This way if a PR breaks the environment or tests, we'll know it.

jglev commented 7 years ago

I'll click Approve on this as soon as you confirm the one question I brought up.

dhimmel commented 7 years ago

CI is nice because it makes it easy to catch things like the environment issue from #10 (see the corresponding build failure).

Do we need to add . to the PATH / PYTHONPATH to the Travis setup?

At the moment this isn't required for the existing tests. I'm not sure modifying your PATH is the right solution. We should try to make it so you can run your commands from the repo and they work based on relative links.

Perhaps save this issue for another PR that actually runs the scripts?

jglev commented 7 years ago

Sure!

jglev commented 7 years ago

I don't see a button at this point to do an official "Approve" step for review. To clarify, should I be seeing that, or can you just merge at this point?

dhimmel commented 7 years ago

I don't see a button at this point to do an official "Approve" step for review. To clarify, should I be seeing that, or can you just merge at this point?

Under files changed, click review changes. Then you can select Approve. I can merge now, but might as well get the official approval as best practice.

jglev commented 7 years ago

Thanks!