greenelab / meta-review

Manuscript describing open collaborative writing with Manubot
https://greenelab.github.io/meta-review
Other
48 stars 21 forks source link

Comments from review of initial submission #124

Closed ctb closed 5 years ago

ctb commented 5 years ago

review comments/requests: see

note these refer to the submitted version of this paper that I received in PDF form; will need to be double checked against latest version.

tpoisot commented 5 years ago

I'd need to read a bit more to comment - just to be clear, is that an invitation to give feedback? I would be happy to, but I'm on parental leave until March.

ctb commented 5 years ago

I put this in to give the editor and other reviewer a single point of entry.

slochower commented 5 years ago

@ctb Yep, got it, sorry for the confusion. I was a little slow on figuring out what was going on.

ctb commented 5 years ago

I also wasn’t clear ;). Battling bad WI-FI and a plane about to take off! I’ll fix this issue up in a bit.

ctb commented 5 years ago

description & issue title fixed. please leave me to update the checkboxes for second review!

agitter commented 5 years ago

Thanks for the comments and for reorganizing the issue @ctb. Would you like us to have you review the pull requests that we create to close these issues? That would ensure we're addressing the comments properly, but I also don't want to commit you to more frequent reviewing if that isn't your intention.

ctb commented 5 years ago

Would you like us to have you review the pull requests that we create to close these issues? That would ensure we're addressing the comments properly, but I also don't want to commit you to more frequent reviewing if that isn't your intention.

I'm traveling, so probably can't do much. But please ask for clarifications if needed!

slochower commented 5 years ago

@dhimmel @agitter Do you want to assign specific people to tackle specific issues or some other alternative strategy?

dhimmel commented 5 years ago

Do you want to assign specific people to tackle specific issues or some other alternative strategy?

How about first one to volunteer or open a PR addressing a piece of feedback gets it. Let's try to keep PRs small, review fast, and merges frequent. @agitter did you want to create response-to-reviewers.md or should I?

agitter commented 5 years ago

@agitter did you want to create response-to-reviewers.md or should I?

I'm on it now. Sooo many meetings this week.

agitter commented 5 years ago

My plan for this issue is to start making pull requests to address the individual comments and close the respective issues. Once they are all finished, we can discuss the batch of changes here and reopen issues that need more revisions.

agitter commented 5 years ago

@ctb thank you for all of your feedback on the Manubot manuscript and organizing it in issues. We're getting close to resubmitting. Is it okay with you if we acknowledge your public review (#126)?

We have also been checking the boxes above to help us track what still needs attention. We're happy to discuss individual comments with you any time.

ctb commented 5 years ago

happy to be acknowledged!

dhimmel commented 5 years ago

Looks like we have made revisions to address each of the issues above.

We can leave this open for @ctb to close if he agrees we've addressed the issues?

agitter commented 5 years ago

Closing this as part of the v3.0 submission. We could reopen or make new issues for additional discussion.