Closed arielah closed 3 years ago
This looks really good!
Two minor initial comments while I am installing it and running checks:
scater
needs to be added to Suggests:
in DESCRIPTION
for the vignetteTitle
line in DESCRIPTION
(probabilistic)A few more things from the checks I just ran - devtools::check()
and BiocCheck::BiocCheck()
in R-devel / Bioc-devel:
@examples
all need library(scater)
(for addPerCellQC
) - this currently gives an error on devtools::check()
:
❯ checking examples ... ERROR
Running examples in ‘miQC-Ex.R’ failed
...
could not find function "addPerCellQC"
Execution halted
❯ checking for unstated dependencies in examples ... WARNING
'::' or ':::' import not declared from: ‘BiocParallel’
library(BiocParallel)
at the top of the example, and remove the ::
rmarkdown
not being available for the vignette - I think this can be fixed by putting rmarkdown
in Suggests:
in DESCRIPTION
miQC.Rproj
should be removed from the GitHub repo by adding it to .gitignore
(this is currently a NOTE)inst/NEWS
. This has a specific format and can be updated later when you add new versions.Then some additional things that I would describe as more optional, but also very useful:
This should be able to go on bioconductor, it has passed BiocCheck() without errors or warnings, but there were a couple notes and any recommendations for style changes or additions would be appreciated.