search

greenelab / mpmp

Multimodal Pan-cancer Mutation Prediction
BSD 3-Clause "New" or "Revised" License
7 stars 6 forks source link

Refactor plotting code in notebooks #51

Closed jjc2718 closed 3 years ago

jjc2718 commented 3 years ago

Closes #18.

There's currently a lot of duplicated code in the notebooks I'm using to plot my results. I'm making similar types of plots between experiments, so I decided to refactor the code to make these common plots into shared functions.

This cuts down considerably on the complexity of the plot notebooks and creates a single point of truth for some of the details (so if I change these plots in the future I only have to do it in one place, rather than in each notebook individually).

jjc2718 commented 3 years ago

Tests are failing because of an ongoing issue with GitHub Actions (see: https://www.githubstatus.com/)

I'll wait a bit to see if the issue resolves, but if not I'll just merge. I ran the tests locally and they all passed.