search

greenelab / scrumlord

Continuous administration of the Greene Lab's electronic scrum
BSD 3-Clause "New" or "Revised" License
13 stars 8 forks source link

travis-ci crontab check #3

Open MarvinT opened 6 years ago

MarvinT commented 6 years ago

Is the crontab check necessary?

My understanding is that it acts to make sure the script only runs when the crontab triggers it, i.e. excluding runs after commits.

However, since the code is(?) robust to running multiple times, this seems to only stymie initial setup attempts.

I can submit a pr to address this if its ok to remove it

dhimmel commented 6 years ago

Here is the code in question:

https://github.com/greenelab/scrumlord/blob/9d43aa334e957ff1f5c7b7b7df25ed747ee6f891/.travis.yml#L13-L15

I think the $TRAVIS_EVENT_TYPE = "cron" logic is also preventing attempted upkeep after_success on pull requests.

However, since the code is(?) robust to running multiple times, this seems to only stymie initial setup attempts.

It should be. However, users can get used to the scheduled jobs occurring at roughly the same time every day. I don't have a strong opinion on whether non-cron commits to master should trigger upkeep, so @MarvinT if the current design is a problem for you, we could change it.

MarvinT commented 6 years ago

I've solved it by just creating an extra branch

Maybe I can just add that as a note in deployment instructions.