search

greenelab / staNMF

A python implementation of Stability NMF
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

adding spams runtime options to runNMF function #3

Closed gwaybio closed 8 years ago

gwaybio commented 8 years ago

Currently, the function runNMF() in the file staNMF/staNMF.py has default parameters set for the spams implementation.

Would there ever be a time when an advanced user would want to edit those default params?

I think a potential solution would be to build an additional class (something like spams_params()) that runNMF() uses to run spams. This way, a user can import this class and and pass it as an argument when running the runNMF() function. If a user doesn't set spams_params beforehand, it automatically passes the default arguments you currently have set. Also, the example from Wu et al. should automatically run with the default settings

gwaybio commented 8 years ago

closing this issue as it was resolved with **kwargs in staNMF.runNMF