Fixing bugs, updating git repo to match PyPi

greenelab / staNMF

A python implementation of Stability NMF

BSD 3-Clause "New" or "Revised" License

6 stars 3 forks source link

Fixing bugs, updating git repo to match PyPi #6

Closed amyecampbell closed 8 years ago

cgreene commented 8 years ago

LGTM :+1:

I think that for importable code in particular it can be helpful to use loggers. My recommendation is to create an issue about converting print statements to loggers before merging, and then address the issue separately. You could, if you wished, change that in this PR but it seems beyond the scope.

dhimmel commented 8 years ago

Other than my comments, looks good to me.

dhimmel commented 8 years ago

No more feedback on my end, so merge at will.

cgreene commented 8 years ago

w/ new issue 👍 LGTM