search

greenelab / tybalt

Training and evaluating a variational autoencoder for pan-cancer gene expression data
BSD 3-Clause "New" or "Revised" License
162 stars 61 forks source link

Adding High Weight Gene Analysis #95

Closed gwaybio closed 6 years ago

gwaybio commented 6 years ago

The pull request is one addition broken down into two parts:

  1. High weight gene analysis (high_weight_genes.ipynb)(d1f0629)(main reviewer: @jaclyn-taroni )
  2. Methods to facilitate analysis (tybalt/genes.py)(a74894b)(main reviewer: @danich1 )

This PR also marks the beginning of a tybalt refactoring process to move most python functions and methods into import-able modules that will live in the tybalt folder. I think splitting the major review portion as I outlined above would be best, but feel free to review as you wish!

gwaybio commented 6 years ago

This PR also closes #69 as the methods provide functionality to instantaneously extract high weight genes given specific high weight gene definitions and a feature matrix.

gwaybio commented 6 years ago

Thanks @danich1 and @jaclyn-taroni - I believe I addressed all comments in 44e7862 . Ready for re-review!