greenelab / word-lapse

Explore how a word changes over time
https://greenelab.github.io/word-lapse/
Other
6 stars 3 forks source link

Change points, switch to d3, animate timeline, matrix viz #12

Closed vincerubinetti closed 2 years ago

vincerubinetti commented 2 years ago
netlify[bot] commented 2 years ago

✔️ Deploy Preview for word-lapse ready!

🔨 Explore the source changes: 2543e451460362f976f6653572133c5b12c4cf1c

🔍 Inspect the deploy log: https://app.netlify.com/sites/word-lapse/deploys/61fd86121ad98a00085bf3d7

😎 Browse the preview: https://deploy-preview-12--word-lapse.netlify.app/

falquaddoomi commented 2 years ago

Looks good so far! I'm a little concerned that the search box is a bit too quick to query considering how long it's actually going to take and the server load it can cause. Maybe having them press a button to search, rather than firing off searches as they're typing, would make it more intentional?

vincerubinetti commented 2 years ago

Looks good so far! I'm a little concerned that the search box is a bit too quick to query considering how long it's actually going to take and the server load it can cause. Maybe having them press a button to search, rather than firing off searches as they're typing, would make it more intentional?

Note this comment:

Screen Shot 2022-02-04 at 1 22 00 PM

I temporarily decreased the debounce so we could test it more quickly. If you type you get a 10% chance of error (so you can see the error message/status), then 25% chance of a long query (so you can see the loading animations).

falquaddoomi commented 2 years ago

Frankly, it's not just the debounce time that's a problem. The UI suddenly and dramatically changes when you start typing, without any animation to indicate that the box you were typing into in the center of the screen has now moved up to the right. At least if they pressed a button they'd have an idea that they were navigating to what appears to be a new page.

Just to clarify, I'm not asking for an animation, just perhaps a search button that they manually click.

vincerubinetti commented 2 years ago

In this case the debounce also determines when it goes out of "fullscreen mode", not just when the API is hit. So with the original intended 1s debounce, I think that will be enough time for the user to finish typing their single word to search.

It's a minor point, but I'd like to have an auto-search for this, to allow users to get results without any further (beyond typing in their word) action. Right now, pressing enter also instantly submits the form (for the benefit of fast typers I guess). I could add a button for that kind of instant submit as well, but I'd still want to keep the auto-search.

I've added back in the long debounce and a header animation.

falquaddoomi commented 2 years ago

That animation you added improves the experience substantially for me; apologies that I didn't realize that it was in earlier and just disabled temporarily. I defer to you on leaving the auto-search in.

vincerubinetti commented 2 years ago

If we see users are hesitating and making a lot of partial searches, like "supercalifragil", then we can consider increasing the debounce or removing the auto-search, for the benefit of UX and/or server load. But I'm hoping 1 second will be enough for most people.

vincerubinetti commented 2 years ago

@falquaddoomi @danich1 added tooltips to data points