search

greenelab / word-lapse

Explore how a word changes over time
https://greenelab.github.io/word-lapse/
Other
6 stars 3 forks source link

Adds backend support for pubtator #46

Closed falquaddoomi closed 2 years ago

falquaddoomi commented 2 years ago

This PR adds support for the 'pubtator' corpus and removes the 'fulltext' and 'abstracts' corpora.

...I was also about to change the frontend to support the change in corpora, but it looks like it's reading the corpora set from the API's metadata endpoint. Nice work, Vince!

netlify[bot] commented 2 years ago

Deploy Preview for word-lapse canceled.

Name Link
Latest commit f895b079e4d79a18acc6c832fb745eb63625ad36
Latest deploy log https://app.netlify.com/sites/word-lapse/deploys/625d84de1869d400097d64d0
cgreene commented 2 years ago

Just to check - does this change the user-selectable name of the corpus? I think this is a full-text corpus, so I think we should name it something meaningful to users ("PMC Full Text" or "PMCOA Full Text" or the like). I don't think folks will generally be familiar with pubtator.

falquaddoomi commented 2 years ago

@cgreene it currently does, yes: users will see "pubtator" in the UI. I'll change the corpora set to a dict of internal IDs to human-readable labels, and modify the frontend to use the label rather than the ID.

falquaddoomi commented 2 years ago

@vincerubinetti just FYI, I modified a bit of the frontend code in this PR to deal with the fact that CORPORA_SET is now a dict of (id, label) pairs, not a list of strings. In order to not mess up your code too much, I used just the label part in the same way you were using what was once the corpus ID/label, and modified the backend to take either the corpus ID or the corpus label.