search

greenelab / word-lapse

Explore how a word changes over time
https://greenelab.github.io/word-lapse/
Other
6 stars 3 forks source link

add metadata links to tagged words #56

Closed vincerubinetti closed 2 years ago

vincerubinetti commented 2 years ago

Closes #39

netlify[bot] commented 2 years ago

Deploy Preview for word-lapse ready!

Name Link
Latest commit 2072fdcbfb2ca074317cd58e58811fe4d37a76f7
Latest deploy log https://app.netlify.com/sites/word-lapse/deploys/627972991cdcc500082bc132
Deploy Preview https://deploy-preview-56--word-lapse.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vincerubinetti commented 2 years ago

@danich1 Please take a close look at these lines of code and tell me if that logic will always work.

I'm basically splitting the tag by _, then taking the first entry as the "prefix" and the last entry as the "id" (because I saw some that were e.g. disease_mesh_1234). Then I take the upper case of the id.

vincerubinetti commented 2 years ago

There are also tags like this:

image

Where tag_id is just mesh.

danich1 commented 2 years ago

@danich1 Please take a close look at these lines of code and tell me if that logic will always work.

Your logic works as the correct tags should be in this form. There may be instances where as described in your last comment where the tags are off. This issue happens as that specific ID is no longer used in the Mesh terminology and Pubtator Central didn't update their tagging list. Not much we can do to fix that. Your solution works as users would just google search it anyways and quickly see that ID is obsolete.