search

greenelab / xswap-manuscript

Manuscript on XSwap network permutation and hetnet node degrees
https://greenelab.github.io/xswap-manuscript/
Other
3 stars 5 forks source link

Add node degree subsection #7

Closed zietzm closed 5 years ago

zietzm commented 5 years ago

https://github.com/greenelab/xswap-manuscript/pull/7/commits/6afe9c5ab9fe7ad252f9b2cf490f55644d4d18ab split the figure into three conceptually distinct parts. I have ordered them according to the order in which they are referenced in the text, and I placed them near the first references to each.

I do not have a preference for figure placement (introduction vs results or relative to paragraphs), so happy to adjust them depending on what others think may be most helpful.

zietzm commented 5 years ago

I think this PR is ready for re-review.

I went back through to split up two paragraphs and move sentences around. I hope the clarity and readability has been increased.

The first two figures have been removed, as well as references to them or the analysis they contain. I am working on those within the Results section as a separate PR. I did keep the Hetionet degree distribution figure since it visualizes existing data to illustrate the diversity of degree distributions.

Edit: Since the edge prediction section has been moved (#11) and the feature-degree correlation figure will go in Results, I removed the introduction subsection headers.

zietzm commented 5 years ago

As I was reading, it felt like we were jumping back and forth between the points instead of going down a list. Can you take a look and see if you agree?

I definitely agree with this assessment.

I tried to rearrange some of the sentences and paragraphs as you suggest, and I think the ordering of key points should now be coherent and linear.