search

greenfork / nimraylib_now

The Ultimate Raylib gaming library wrapper for Nim
MIT License
149 stars 16 forks source link

Jseb #35

Closed jeangit closed 3 years ago

jeangit commented 3 years ago

everything should be reverted now. (basically, adding find_missing_examples.nim again, and .gitignore…) for .gitignore, i think it should stay local in a shared project like this.

greenfork commented 3 years ago

Could you also follow steps 5 and 6 from converting examples? https://github.com/greenfork/nimraylib_now/blob/master/CONTRIBUTING.md

I think you missed this comment?

jeangit commented 3 years ago

i have read CONTRIBUTING but was focalized of the source itself with NEP1 rules , and forgot the test suite part.

greenfork commented 3 years ago

@jeangit do you want to do final fixes or I can do them for you?

jeangit commented 3 years ago

sorry i haven't seen this message. Yes, you can tune as you want the sample.

greenfork commented 3 years ago

@jeangit no problem. And by the way, git saves the history of the code. For example, if you did some changes, it is recorded in the git history. And if I do any changes on top of it, the authorship of the code according to git will belong to us 2. So if you don't mind, I will just do several slight changes in this same PR and commit our work together. I think it is important to give the credit for the work like that.