search

greenfrvr / hashtag-view

Android fully customizable widget for representing data like hashtags collection and similiar.
MIT License
336 stars 54 forks source link

Item is wider than widget #4

Closed greenfrvr closed 9 years ago

greenfrvr commented 9 years ago

There is an unhandled case. When the value of measured text width + left/right paddings + left/right drawables is greater than total widget width, an infinite loop appears on items sorting step.

lawloretienne commented 9 years ago

I'm not sure why, but the version in your README does not match the version available here http://gradleplease.appspot.com/#hashtag-view

greenfrvr commented 9 years ago

are you using mavenCentral? sorry, that's was my fault, I forgot to sync bintray repo with mavenCentral, now last version should be available.

lawloretienne commented 9 years ago

I'm using jCenter() which I think is the preferred repo over mavenCentral(). I just checked again. I think it takes a few hours to go live before it shows up on http://gradleplease.appspot.com/#hashtag-view

lawloretienne commented 9 years ago

I just tested this again in v1.1.1 and it still is an issue.

greenfrvr commented 9 years ago

Can't really get where is the problem. I have tested widget with long tags and it worked fine. Did you try to use tagMaxWidth property?

lawloretienne commented 9 years ago

Okay I figured out the issue, I added paddingLeft and paddingRight to the HashtagView style and this is what caused the garbage collection to happen.

<style name="HashtagView">
        <item name="android:layout_width">match_parent</item>
        <item name="android:layout_height">wrap_content</item>
        <item name="android:paddingLeft">16dp</item> <!-- Changed -->
        <item name="android:paddingRight">16dp</item> <!-- Changed -->
        <item name="android:paddingTop">16dp</item> <!-- Changed -->
        <item name="tagTextSize">16dp</item> <!-- Changed -->
</style>
greenfrvr commented 9 years ago

finally I got the problem, fixed in v1.2.0