search

greenfrvr / hashtag-view

Android fully customizable widget for representing data like hashtags collection and similiar.
MIT License
336 stars 54 forks source link

RecyclerView and HashtagView #8

Closed claudiopastorini closed 8 years ago

claudiopastorini commented 9 years ago

Hi I have some problems using your library in my project with a RecyclerView (in particular with Material List). I have a list of cards with some text and HashtagView. The first time the cards are populated in the right way, when I scroll cards are populated in the right way except that HashtagView that reuse previous tags.

I believed that the problem was in your view because I read that you don't call anytime invalidate() when data are setted. After that I added those calls in your code the result is the same.

So I don't understand where is the problem.. I tried to add some log in your code and when I setData the log works, so I believed that the problem is in the RecyclerView that doesn't redraw your view. I don't know why...

greenfrvr commented 9 years ago

I'll try investigate this issue anytime soon.

claudiopastorini commented 9 years ago

I implemented an example of use of RecyclerView. See my fork.

I think that the problem occurs because you call draw() only on preDraw(). You should call it every times setData() is called but this compromises everything that you have created XD.

greenfrvr commented 9 years ago

Thanks for your RecyclerView example. I solved the problem of using previous tags in RecyclerView that you described, but there is still some issues with setting empty arrays as a data. Currently working on it)

claudiopastorini commented 9 years ago

Maybe I solved the issue with empty arrays. I created a dummy ItemData and when it occurs I set the view's visibility to GONE. It keeps crashing with IllegalStateException but I forced it to remove views in draw()'s for and now it doesn't crash anymore. See here.

Now I want to understand how sort() works because it orders in different way the same content during the scrolling. There is also another problem, the scroll is "jerky". I suppose it is caused by the loading of the previous/following row.

greenfrvr commented 9 years ago

That's quite tricky issue, I made several fixes which allow handling empty arrays, but it still crashing on fling event.

claudiopastorini commented 9 years ago

Did you see my code?

greenfrvr commented 8 years ago

Try to pull last updates. It seems the problem is solved. Sorry for such a long pause. Hope your'e still interested in library.