Closed kanema closed 7 years ago
+1
@kanema @thoop thanks. I will look at it.
@kanema - We noticed a problem with the nuget install script. It sets the crawlerUserAgents to some nonsense ("me,you,she,he"), but unfortunately, this causes Chrome to be treated as a crawler, since "me" is part of the User Agent string for Chrome. Any chance of that getting changed to something less error prone? I'd be happy to do it, but the nuget files aren't in the repo.
@kanema .This is my demo code. Nuget is release by other guy. I will try to do a new one.
I realize that @greengerong. I was hoping I would get a response from @kanema. Thanks for your work on this project!
@kanema move to demo project out,now.
I added a PR that consolidates the source code with Nuget package and makes namespace and stuff make more sense.
https://github.com/greengerong/Prerender_asp_mvc/pull/12
please review and accept
@brgrz accepted.
@kanema How do we update the Nuget package? Also, could you bring the Nuget bits in here?
Thought I'd +1 getting the nuget package updated, I just got tripped up by the differences as the nuget package wasn't working correctly for me (not sending through escaped_fragment to the prerender service) but building from source works correctly, so I guess it's something that was changed after the nuget package was generated. Not sure if there's any way I can help with this, I guess the owner on nuget.org needs to manage it?
I tried to contact @kanema about updating the nuget package but never heard back. Maybe the ping on github will do the trick :)
Long time no response. I think we can close.
I took the liberty of putting the package available via nuget. To do this i change the namespace from Prerender_asp_net to Prerender.io. https://www.nuget.org/packages/Prerender.io/ Maybe ia a good idea divide in two projects, the module and the demo.