search

greengerong / Prerender_asp_mvc

Prerende client for asp.net mvc
http://prerender.io/
86 stars 39 forks source link

504 for https #27

Open Uncle-Bens opened 7 years ago

Uncle-Bens commented 7 years ago

Hi! I use prerender on my own server and have respond 504 for https and 200 for http. prerender 504 edited

Could you please help.

thoop commented 7 years ago

Which version of this middleware are you using? That bug should have been fixed a long time ago:

https://github.com/greengerong/Prerender_asp_mvc/commit/b11ebecafab5bef62832c40444ee782fc25e53a9

Can you update to the latest code?

jaandrews commented 7 years ago

I'm encountering this issue as well. I currently have 1.0.0.2 installed via nuget. Maybe there's an issue with the nuget package? I checked the code in the repository and it looks correct.

thoop commented 7 years ago

I think the nuget package hasn't been updated in a long time. Can you post a link to that repository so we can take a look?

jaandrews commented 7 years ago

Sorry I wasn't clear enough. What I meant was that I checked the Prerender_asp_mvc repository to confirm that the old code hadn't somehow found its way back in (it hadn't).

I tried installing the nuget package in a new project and confirmed that the dll is too old. Here is a screen shot of the dll added by the nuget package. prerender-issue The dll was last modified 6/30/14, which would be before the fix was in place.

I should be able to get around this by pulling it down and building it myself, so this isn't an urgent issue for me, but it would be nice to have the nuget package up to date.

thoop commented 7 years ago

Sorry about that! I think that nuget package was uploaded by a random person and we haven't been able to get in touch with them. We might have to upload an official one under a different name.