search

greenheartgames / greenworks

a node.js plugin to integrate nw.js/electron games with steamworks
MIT License
1.49k stars 154 forks source link

Utils.extractArchive call changes working directory #172

Open MyEyes opened 6 years ago

MyEyes commented 6 years ago

https://github.com/greenheartgames/greenworks/blob/master/src/greenworks_unzip.cc#L301

When using the utility function the working directory is changed to the destination directory. I feel like either the working directory should be restored afterwards or the documentation should be more clear.

hokein commented 6 years ago

Thanks for the report.

I'd say this is a bug, the working directory should not be changed after calling the extractAchive. Patches are welcome :)