search

greenjava / win-ldd

ldd for Windows
MIT License
3 stars 4 forks source link

2 issues. first don't use uppercase header name. it should dbghelp.cpp. another is a incorrect free #2

Open trcrsired opened 2 months ago

trcrsired commented 2 months ago

~/toys $ clang++ -o win-ldd.exe win-ldd.cpp -O3 --target=aarch64-windows-msvc --sysroot=$MSVCSYSROOT -D_DLL=1 -lmsvcrt -fuse-ld=lld win-ldd.cpp:8:10: fatal error: 'Dbghelp.h' file not found 8 | #include | ^~~ 1 error generated. ~/toys $ vim win-ldd.cpp ~/toys $ clang++ -o win-ldd.exe win-ldd.cpp -O3 --target=aarch64-windows-msvc --sysroot=$MSVCSYSROOT -D_DLL=1 -lmsvcrt -fuse-ld=lld win-ldd.cpp:33:13: warning: 'delete' applied to a pointer that was allocated with 'new[]'; did you mean 'delete[]'? [-Wmismatched-new-delete] 33 | delete strDLLPath; | ^ | [] win-ldd.cpp:30:34: note: allocated with 'new[]' here 30 | LPTSTR strDLLPath = new TCHAR[_MAX_PATH]; | ^ 1 warning generated.

trcrsired commented 2 months ago

small issues like use std::endl should be avoided too

trcrsired commented 2 months ago

image

BTW. the performance is very slow due to std::endl i guess

trcrsired commented 2 months ago

i have submitted pr to fix issues