greenkeeper-keeper / hapi-greenkeeper-keeper

hapi plugin to automatically merge and clean up passing greenkeeper PRs
MIT License
5 stars 4 forks source link

An in-range update of @octokit/rest is breaking the build 🚨 #650

Closed greenkeeper[bot] closed 4 years ago

greenkeeper[bot] commented 4 years ago

☝️ Important announcement: Greenkeeper will be saying goodbye πŸ‘‹ and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency @octokit/rest was updated from 17.2.1 to 17.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@octokit/rest is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **Travis CI - Branch:** The build **errored**.

Release Notes for v17.3.0

Features

  • simpler pagination using endpoint methods as first argument (#1672) (548d65a)

Before

const options = octokit.issues.listForRepo.endpoint.merge({
  owner: "octokit",
  repo: "rest.js",
});
const issues = await octokit.paginate(options);

After

const issues = await octokit.paginate(octokit.issues.listForRepo, {
  owner: "octokit",
  repo: "rest.js",
});
FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 4 years ago

After pinning to 17.2.1 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version πŸš€

Release Notes for v17.4.0

17.4.0 (2020-04-19)

Features