greenkeeperio / greenkeeper-lockfile

:lock: Your lockfile, up to date, all the time
https://greenkeeper.io
183 stars 73 forks source link

fix: Jenkins multibranch #180

Closed sgtcoolguy closed 6 years ago

sgtcoolguy commented 6 years ago

This is a follow-on to #165

greenkeeper-lockfile-upload will ignore gitURL and use repoSlug when using the env.GH_TOKEN (see https://github.com/greenkeeperio/greenkeeper-lockfile/blob/master/upload.js#L47-L48). I did not attempt to fix that, but instead overhauled the jenkins CI impl to provide both gitURL and repoSlug.

I also tweaked it to be much more exhaustive in attempting to get the git URL (and therefore the slug) by consulting, in order:

patkub commented 6 years ago

@sgtcoolguy Travis build fails because of code format. Run standard --fix and commit changes to resolve.

janl commented 6 years ago

@sgtcoolguy heya, overall this looks great. Can you look at the test errors reported by Travis?

sgtcoolguy commented 6 years ago

@janl ok, I think I fixed the issue now. Needed to update the test setup/snapshot to handle/expect a call to git config remote.origin.url (actually twice in the monorepo root package case)

janl commented 6 years ago

perfect, thanks!

greenkeeperio-bot commented 6 years ago

:tada: This PR is included in version 2.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: