search

greenkeeperio / greenkeeper-lockfile

:lock: Your lockfile, up to date, all the time
https://greenkeeper.io
182 stars 73 forks source link

fix(hasLockfileCommit): specify origin when fetching #184

Closed tagoro9 closed 6 years ago

tagoro9 commented 6 years ago

There is more context in https://github.com/greenkeeperio/greenkeeper-lockfile/issues/164#issuecomment-405308480

When configuring the remote to use GH_TOKEN in upload.js it is only done for the gk-origin remote, but then in git-helpers#hasLockfileCommit a git fetch is done, which can fail if there is a origin remote defined, as this one is not configured with GH_TOKEN.

This PR updates hasLockfileCommit to make the fetch from gk-origin.

janl commented 6 years ago

excellent, thanks!

greenkeeperio-bot commented 6 years ago

:tada: This PR is included in version 2.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

mAAdhaTTah commented 6 years ago

This command appears to be failing for a couple people, as noted in #164. Would opening a new issue be more helpful or is this already being investigated?

janl commented 6 years ago

I'm looking at 164, but I ran out of time to day and I'm off work now. I'll be looking at this again tomorrow.