search

greenkeeperio / greenkeeper-lockfile

:lock: Your lockfile, up to date, all the time
https://greenkeeper.io
183 stars 73 forks source link

fix: Fix `SyntaxError: Identifier 'flag' has already been declared` #54

Closed sudo-suhas closed 7 years ago

sudo-suhas commented 7 years ago

I have faced the following issue multiple times in node 4 env:

$ greenkeeper-lockfile-update

/home/travis/.config/yarn/global/node_modules/greenkeeper-lockfile/lib/update-lockfile.js:39
      const flag = flags[dependency.type]
      ^
SyntaxError: Identifier 'flag' has already been declared
    at updateLockfile (/home/travis/.config/yarn/global/node_modules/greenkeeper-lockfile/lib/update-lockfile.js:23:42)
    at Module.update [as exports] (/home/travis/.config/yarn/global/node_modules/greenkeeper-lockfile/update.js:60:3)
    at Object.<anonymous> (/home/travis/.config/yarn/global/node_modules/greenkeeper-lockfile/update.js:68:37)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at startup (node.js:140:18)
    at node.js:1043:3

The command "greenkeeper-lockfile-update" failed and exited with 1 during .

This error was reported in #49 and was closed by PR #51. I don't think the issue was because of the missing 'use strict' directive:

λ node --version
v4.0.0

λ echo let a = 1 > test-node4.js

λ node test-node4.js
E:\Projects\experiments\test-node4.js:1
(function (exports, require, module, __filename, __dirname) { let a = 1
                                                              ^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:413:25)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:475:10)
    at startup (node.js:117:18)
    at node.js:951:3

For some reason, both options.yarn and options.npm must be truthy which leads to flag being declared twice. This fixes the issue with an else if

sudo-suhas commented 7 years ago

Just realised this would break simultaneous update of package-json.lock and yarn.lock.

sudo-suhas commented 7 years ago

Will reopen this PR with different solution if I face the issue again.