search

greenkeeperio / greenkeeper-lockfile

:lock: Your lockfile, up to date, all the time
https://greenkeeper.io
183 stars 73 forks source link

fix: Jenkins CI fix #64

Closed absolutehype closed 6 years ago

absolutehype commented 6 years ago

The branchName requires the greenkeeper/ prefix in order to continue.

This continually fails on Jenkins with the message below when trying to setup Greenkeeper (branch name being greenkeeper/initial)

initial is not a Greenkeeper branch

https://github.com/greenkeeperio/greenkeeper-lockfile/blob/3f8726855da777f8caf66e50b7ec5af6a2774468/update.js#L46-L48

I'm updating branchName so that it no longer strips the prefix. This aligns the Jenkins implementation with the other CI services

https://github.com/greenkeeperio/greenkeeper-lockfile/blob/3f8726855da777f8caf66e50b7ec5af6a2774468/ci-services/travis.js#L7 https://github.com/greenkeeperio/greenkeeper-lockfile/blob/3f8726855da777f8caf66e50b7ec5af6a2774468/ci-services/circleci.js#L7

Realtin commented 6 years ago

I think I remember @finnp put this: _.drop(_.split(env.GIT_BRANCH, '/')).join('/') in because of the other Jenkins Git plugin which puts some additional 'xyz/' to the env.GIT_BRANCH.

can you confirm @finnp ?

so we need both versions depending on how many '/' are in env.GIT_BRANCH

absolutehype commented 6 years ago

Bump. Any update on this @finnp?

janl commented 6 years ago

Closing in favour #73 which seems more far-reaching and includes this.