search

greenkeeperio / greenkeeper-lockfile

:lock: Your lockfile, up to date, all the time
https://greenkeeper.io
182 stars 72 forks source link

Cannot run with yarn option --ignore-engines #66

Closed elenadimitrova closed 7 years ago

elenadimitrova commented 7 years ago

The way we update the lock file currently is using the --ignore-engines option as we're using packages on node 4 which require a higher version (e.g. 6.5), one example below Therefore the greenkeeper-lockfile-update command in CI fails with error e.g:

error ethjs-abi@0.1.8: The engine "node" is incompatible with this module. Expected version ">=6.5.0".
error Found incompatible module

We should be able to pass options to yarn via the greenkeeper-lockfile-update script

janl commented 7 years ago

Excellent observation! By my estimation, we’d accept a PR that would read a GK_LOCK_YARN_OPTS environment variable that then get passed into yarn here: https://github.com/greenkeeperio/greenkeeper-lockfile/blob/master/lib/update-lockfile.js#L37

Would you be interested in providing a PR?

chmanie commented 7 years ago

I took a shot at it here: #78. Feel free to review :)

Realtin commented 7 years ago

https://github.com/greenkeeperio/greenkeeper-lockfile/pull/78 is now merged :)