I use Heroku CI for my project, and I'd like to create a PR that adds support for it. However, there's a few things that Heroku does not give me in their CI environment, one of which the GitHub repo URL. However, I can set environment variables in the CI environment.
Would you be against me pulling the GitHub URL from the environment, expecting that users of greenkeeper-lockfile will have set that value themselves? This will of course lead to errors if the user doesn't set the variable.
Next, there's a the concept of firstPush. I understand this to mean that the lockfile should be checked and updated if a PR is opened, but not if a PR is updated.
Unfortunately, Heroku's CI environment completely removes the .git directory after cloning, and as far as I can tell, there's no way for me to actually run git commands locally on the CI server (which would prevent me from using the getNumberOfCommitsOnBranch helper). I don't want to force update checks on every single commit, but I'm not sure what a good solution would be.
Lastly, I don't fully understand what correctBuild means. I would expect that I'd want to run the lockfile check on every PR, so that things are fully updated before I merge into master. Can this key be clarified?
Hey Greenkeeper,
I use Heroku CI for my project, and I'd like to create a PR that adds support for it. However, there's a few things that Heroku does not give me in their CI environment, one of which the GitHub repo URL. However, I can set environment variables in the CI environment.
Would you be against me pulling the GitHub URL from the environment, expecting that users of
greenkeeper-lockfilewill have set that value themselves? This will of course lead to errors if the user doesn't set the variable.Next, there's a the concept of
firstPush. I understand this to mean that the lockfile should be checked and updated if a PR is opened, but not if a PR is updated.Unfortunately, Heroku's CI environment completely removes the
.gitdirectory after cloning, and as far as I can tell, there's no way for me to actually run git commands locally on the CI server (which would prevent me from using thegetNumberOfCommitsOnBranchhelper). I don't want to force update checks on every single commit, but I'm not sure what a good solution would be.Lastly, I don't fully understand what
correctBuildmeans. I would expect that I'd want to run the lockfile check on every PR, so that things are fully updated before I merge intomaster. Can this key be clarified?