search

greenkeeperio / greenkeeper

:robot: :palm_tree: Real-time automated dependency updates for npm and GitHub
https://greenkeeper.io/
Apache License 2.0
1.6k stars 95 forks source link

Greenkeeper may create corrupted branches #527

Open xPaw opened 6 years ago

xPaw commented 6 years ago

This has happened twice in our project now, greenkeeper makes a branch which has corrupted data for whatever reason, and then the whole git repository becomes unusable until the branch is deleted.

GitHub displays "Sorry, this diff is unavailable. The repository may be missing relevant data." https://github.com/thelounge/lounge/pull/1590/files

Cloning the repository fails as well:

$ git clone --depth=50 --branch=greenkeeper/eslint-4.8.0 https://github.com/thelounge/lounge.git thelounge/lounge
Cloning into 'thelounge/lounge'...
remote: Counting objects: 2072, done.
remote: Compressing objects: 100% (988/988), done.
remote: fatal: unable to read 2db458563789e37f6d9cf7f53eceedffcf9f595f
remote: aborting due to possible repository corruption on the remote side.
fatal: early EOF
fatal: index-pack failed

https://travis-ci.org/thelounge/lounge/jobs/281475529

gr2m commented 6 years ago

Thanks @xPaw, we’ll look into it the coming week

espy commented 6 years ago

Hi @xPaw, Alex from Greenkeeper here. We’ve been in contact with GitHub and together we think we’ve identified the issue, we’ll try and figure out a solution as soon as we can.

I see that Greenkeeper is working for you again, so it’s good to know you’re not blocked by this. Nevertheless, I’m sorry for the inconvenience. And thanks very much for reporting the issue!

xPaw commented 6 years ago

@espy This has happened once before, and it completely borked the repository (unable to clone or push) until the relevant branch was deleted. But it's good to hear that the issue has been identified.

espy commented 6 years ago

@xPaw one more question: did you do a full reset of the repo (disable/re-enable the Greenkeeper app in the GitHub interface), or did you just delete the branch, and then it recovered by itself?

xPaw commented 6 years ago

I deleted the branch via github UI, and that fixed it.

espy commented 6 years ago

Thanks!

xPaw commented 6 years ago

Here's the first branch that got corrupted, interestingly it's also eslint.

https://github.com/thelounge/lounge/pull/1489

evantahler commented 6 years ago

Confirming that actionhero/actionhero just saw this as well. The PR in question https://github.com/actionhero/actionhero/pull/1124

janl commented 6 years ago

The underlying cause is a combination of the GitHub API and our work queue, but there is a potential fix, we’ll look into that.