search

greenlaw110 / greenscript

A tool help web developers manage javascript/css rendering, including minimize and dependence management
42 stars 24 forks source link

greenscript css request resets PLAY_FLASH cookie #23

Closed scottlet closed 13 years ago

scottlet commented 13 years ago

Took a while to work this out, we had intermittent problems with PLAY_FLASH being wiped, eventually found the culprit:

This response comes from my HTML:

Server: Play! Framework;1.2.3;dev

Content-Type: text/html; charset=utf-8

Set-Cookie: PLAY_FLASH=%00url%3A%2Fsearch%3Fmatch%3Dfeet%26go%3DGo%26compatibility%3D%00;Path=/ PLAY_ERRORS=;Expires=Sat, 5-Nov-11 13:23:03 GMT;Path=/ PLAY_SESSION=173568528f604221761b8b9447afb9874260e402-%00___AT%3A7205f096798cddd5d1a2ff9ad83427161e19ac46%00;Path=/

Cache-Control: no-cache

Content-Length: 22199

Then, almost immediately, the request is made for the CSS:

http://localhost:9000/public/gs/a7e85415-75e3-4c62-a0c5-bcf51155de36.css

which gives this response:

Server: Play! Framework;1.2.3;dev

Content-Type: text/css; charset=utf-8

Last-Modified: Sat, 05 Nov 2011 13:23:03 GMT

Etag: "1320499383470-1898950291"

Cache-Control: max-age=8640000

Set-Cookie: PLAY_FLASH=;Expires=Sat, 5-Nov-11 13:23:03 GMT;Path=/ PLAY_ERRORS=;Expires=Sat, 5-Nov-11 13:23:03 GMT;Path=/ PLAY_SESSION=173568528f604221761b8b9447afb9874260e402-%00___AT%3A7205f096798cddd5d1a2ff9ad83427161e19ac46%00;Path=/

Content-Length: 9750

So the PLAY_FLASH content is wiped out. There's nothing I've seen about this in the documentation and no mention elsewhere but it's quite a major issue for me, now I've found the culprit, and I'm suspecting others may have similar issues but may not have tracked it down yet. Static resources shouldn't be setting cookies really so I can't imagine this is anything other than a bug.

greenlaw110 commented 13 years ago

Hi thx for reporting the issue. Can you send me your email address? I would like to mail you an updated version to see if the issue could be fixed.

scottlet commented 13 years ago

Just in case my mail didn't get to you :) scott@quul.net is my mail address

greenlaw110 commented 13 years ago

Hi my email to scott@quul.net was blocked. Please get the jar file from http://ge.tt/98WqRc9?c and put it into your greenscript module lib folder.

thanks, Green

On Sun, Nov 6, 2011 at 8:57 PM, scottbert < reply@reply.github.com>wrote:

Just in case my mail didn't get to you :) scott@quul.net is my mail address

Reply to this email directly or view it on GitHub: https://github.com/greenlaw110/greenscript/issues/23#issuecomment-2644633

greenlaw110 commented 13 years ago

Hi scott, how you going?, I guess there is a problem in that build. Can you please try this one: http://ge.tt/92l3rj9?c

greenlaw110 commented 13 years ago

Fixed as confirmed by scott's email