greenlaw110 / greenscript

A tool help web developers manage javascript/css rendering, including minimize and dependence management

42 stars 24 forks source link

Browser option not working #31

Open ghost opened 12 years ago

ghost commented 12 years ago

I'm using greenscript 1.2.6m. Loving it so far. Ran into a small problem. The browser option doesn't do anything. If my webpage has

{greenscript.css "base", output:true/}

#{greenscript.css 'base-ie8', browser: 'IE 8', output:true/}

the output is just two lines without the conditional comments.

I noticed a missing underscore in your gs_.html file on line 36. It says browser: browser, but I think it should be browser: _browser. Also, should the media attribute also have an underscore? Not sure, because I haven't tested it.

jtammen commented 12 years ago

Hey,

maybe you can try something like this:

#{greenscript.css 'base' /}
#{greenscript.css 'base-ie8', browser: 'IE 8', media: 'screen' /}
#{greenscript.css output: 'all'}

I needed the media attribute as well as the third greenscript tag in order to get the desired result ... don't know whether this is the way it was intended to work.

I am using Play 1.2.4 and GreenScript version 1.2.7 and no greenscript.conf.