Closed gslowikowski closed 12 years ago
looks good. One thing I found is the "samples-and-tests" folder are missing from the final distribution zip file
On Wed, Feb 22, 2012 at 9:34 PM, gslowikowski < reply@reply.github.com
wrote:
JCoffeeScript
I've deployed "jcoffeescript" and "jcoffeescript-dep" version 1.1 artifacts to my repository. "jcoffeescript" is the original one with Rhino bundled. "jcoffeescript-dep" is the original one, but with Rhino classes removed (by me). The names are just jike in JUnit case, there are two JUnit artifacts: "junit" with dependencies bundled, and "junit-dep" without them.
In "greenscript-core" I added "jcoffeescript-dep" with Rhino dependency excluded (because it's bundled in yuicompressor).
You can merge this Pull Request by running:
git pull https://github.com/gslowikowski/greenscript master
Or you can view, comment on it, or merge it online at:
https://github.com/greenlaw110/greenscript/pull/41
-- Commit Summary --
- JCoffeeScript dependency added.
-- File Changes --
M java/core/pom.xml (12)
-- Patch Links --
https://github.com/greenlaw110/greenscript/pull/41.patch https://github.com/greenlaw110/greenscript/pull/41.diff
Reply to this email directly or view it on GitHub: https://github.com/greenlaw110/greenscript/pull/41
I have this directory in the zip file. Try to build "play" module with "mvn clean package -Pdist" (with "clean" before "package").
hi, yes it come out! this is really cool Thank you very much for all you have done!
On Wed, Feb 22, 2012 at 10:09 PM, gslowikowski < reply@reply.github.com
wrote:
I have this directory in the zip file. Try to build "play" module with "mvn clean package -Pdist" (with "clean" before "package").
Reply to this email directly or view it on GitHub: https://github.com/greenlaw110/greenscript/pull/41#issuecomment-4101999
When you will release your next version, and will announce it, you can add info, that this is the very first Play! module build entirely with Maven :)
One more thing. You asked about pom.xml in the parent directory. You can build both modules with it. Just go to the parent and invoke "mvn clean package -Pdist". Maven will clean and package "core" module and then "play" module. For "core" module "dist" profile will be ignored because this module does not have it in pom file, for "play" - it will be used. When building "play" module, the result of "core" module will be visible, without the need to install it in your local Maven repository ("install" command). This is called "a reactor build" - http://stackoverflow.com/questions/2050241/what-is-the-maven-reactor
Neat!
BTW, could you please catch up the current morphia and send me pull request again? I will merge your updates first this time before any other changes.
Also, I've been working on an new static template engine called rythm, and an new play plugin built on top of it. Here are the links to them, I would like to invite you to mavenize them also:
They are almost ready to release, the only major stuff left is documentation. (Yes I've port zencontact sample to use rythm template engine). The following two benchmark sets shows it's running at japid's speed, but much eaiser to use.
On Wed, Feb 22, 2012 at 10:32 PM, gslowikowski < reply@reply.github.com
wrote:
One more thing. You asked about pom.xml in the parent directory. You can build both modules with it. Just go to the parent and invoke "mvn clean package -Pdist". Maven will clean and package "core" module and then "play" module. For "core" module "dist" profile will be ignored because this module does not have it in pom file, for "play" - it will be used. When building "play" module, the result of "core" module will be visible, without the need to install it in your local Maven repository ("install" command). This is called "a reactor build" - http://stackoverflow.com/questions/2050241/what-is-the-maven-reactor
Reply to this email directly or view it on GitHub: https://github.com/greenlaw110/greenscript/pull/41#issuecomment-4102291
Hi I found the version number of greenscript-core and greenscript-play are coupled together, how can I implement mavenize so that core and play plugin using separate version number?
Hi, you have:
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>greenscript-core</artifactId>
<version>${project.version}</version>
<exclusions>
<exclusion>
<groupId>commons-lang</groupId>
<artifactId>commons-lang</artifactId>
</exclusion>
<exclusion>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
<exclusion>
<groupId>javax.inject</groupId>
<artifactId>javax.inject</artifactId>
</exclusion>
</exclusions>
</dependency>
in greenscript-play's "pom.xml" file. Just change "${project.version}" to the version number you need.
JCoffeeScript
I've deployed "jcoffeescript" and "jcoffeescript-dep" version 1.1 artifacts to my repository. "jcoffeescript" is the original one with Rhino bundled. "jcoffeescript-dep" is the original one, but with Rhino classes removed (by me). The names are just jike in JUnit case, there are two JUnit artifacts: "junit" with dependencies bundled, and "junit-dep" without them.
In "greenscript-core" I added "jcoffeescript-dep" with Rhino dependency excluded (because it's bundled in yuicompressor).