search

greenlion / PHP-SQL-Parser

A pure PHP SQL (non validating) parser w/ focus on MySQL dialect of SQL
BSD 3-Clause "New" or "Revised" License
602 stars 156 forks source link

continue; targetting a switch got deprecated - replaced with break; #304

Closed Axeia closed 5 years ago

Axeia commented 5 years ago

As of PHP 7.3 using a targetting a switch with continue will throw a warning as it's deprecated. It is to be removed in PHP 8 as can be seen here https://wiki.php.net/rfc/continue_on_switch_deprecation

moufmouf commented 5 years ago

Ping! (I badly need this to be merged for TDBM) :)

roxguel commented 5 years ago

In several projects I use TDBM, and when I migrate to PHP 7.3 run into this problem. We look forward to the merger as soon as possible.

gwis-taddev commented 5 years ago

Are these suppose to be break or continue 2 ?

moufmouf commented 5 years ago

@gwis-taddev These are definitely meant to be "break" and not "continue 2". I did some tests and all tests are failing with "continue 2".

This PR is correct.

Any chance we can have this PR merged soon? It is obviously correct and without it, it is impossible to use PHP-SQL-Parser in PHP 7.3 without disabling PHP notices (which is a terrible idea). Ping @greenlion @natsimhan @phpcontrols

nabab commented 5 years ago

Ping! Please that's what prevent us to use 7.3 in production. Thanks!

greenlion commented 5 years ago

I’ll make a new release shortly.

volga commented 5 years ago

Ping! Please, make a new realese.

greenlion commented 5 years ago

https://github.com/greenlion/PHP-SQL-Parser/releases/tag/4.3.0

volga commented 5 years ago

https://github.com/greenlion/PHP-SQL-Parser/releases/tag/4.3.0

Thanks