greenlion / PHP-SQL-Parser

A pure PHP SQL (non validating) parser w/ focus on MySQL dialect of SQL
BSD 3-Clause "New" or "Revised" License
601 stars 156 forks source link

Add Additional Builders for CREATE statements #363

Closed atiernan closed 2 years ago

atiernan commented 2 years ago

This PR adds support for some missing builders when building CREATE statements

The statements above would fail when running the following code

$parser = new \PHPSQLParser\PHPSQLParser();
$creator = new \PHPSQLParser\PHPSQLCreator();
$parsed = $parser->parse($sql);
$creator->create($parsed);
atiernan commented 2 years ago

@greenlion Is there anything I can do to help this along?

greenlion commented 2 years ago

@atiernan Why do the tests fail?

atiernan commented 2 years ago

It seems like the CI pipeline is broken. The majority fail because PHPUnit 9 only supports php 7.3 and up. The 7.3 job fails because PHPUnit_Framework_TestCase no longer exists in PHPUnit 9. If I get some time I'll look it to fixing these in a separate PR

greenlion commented 2 years ago

Ok, I will take a closer look at the PR and get back to you.

On Thu, Jul 28, 2022 at 3:58 AM Alex Tiernan-Berry @.***> wrote:

It seems like the CI pipeline is broken. The majority fail because PHPUnit 9 only supports php 7.3 and up. The 7.3 job fails because PHPUnit_Framework_TestCase no longer exists in PHPUnit 9. If I get some time I'll look it to fixing these in a separate PR

— Reply to this email directly, view it on GitHub https://github.com/greenlion/PHP-SQL-Parser/pull/363#issuecomment-1197798791, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADRTNVJ3VOFRQPOPS5NODDVWI4TJANCNFSM53MNECMA . You are receiving this because you were mentioned.Message ID: @.***>

greenlion commented 2 years ago

Thank you for your contribution.