Remove CHARACTER keyword from column types

greenlion / PHP-SQL-Parser

A pure PHP SQL (non validating) parser w/ focus on MySQL dialect of SQL

BSD 3-Clause "New" or "Revised" License

601 stars 156 forks source link

Closed czoIg closed 8 months ago

czoIg commented 2 years ago

Fixes CREATE TABLE with

`type` varchar (255) CHARACTER SET utf8 NOT NULL

as described in #365.

Also fixes unit tests with old TestCase class.

xsist10 commented 9 months ago

Hi @czoIg.

Thanks for your merge request and the effort you made in fixing the tests.

Does https://github.com/greenlion/PHP-SQL-Parser/pull/376 fix your problem? If so I'll go ahead and request that this MR gets closed and the other gets merged in.

greenlion commented 8 months ago

Merged alternate MR.