search

greenlion / warp

WarpSQL Server, an open source OLAP focused distribution of the world's most popular open source database bundled with OLAP performance related plugins such as the WARP storage engine..
http://warpsql.blog
Other
41 stars 2 forks source link

Missing commits after crash #72

Closed greenlion closed 3 years ago

greenlion commented 3 years ago

fsync() does not flush unflushed data from core to write cache. warp_trx::commit calls fsync() without first calling fflush()

This means that if the server crashes, commits could be lost. That is, uh, BAD. Modify warp_trx::commit to call fflush() followed by fsync().

greenlion commented 3 years ago

Fixed in parallel_query branch in latest checkin.