search

greenpau / caddy-git

Git Plugin for Caddy v2
Apache License 2.0
70 stars 13 forks source link

feature: Secure GitHub webhooks #11

Closed joeworkman closed 2 years ago

joeworkman commented 2 years ago

A clear and concise description of what you want the system to do.

The webhooks feature cannot currently be used properly with Github. The reason for this is that the web hook header needs to be compared securely for each request. It's not as simple as just comparing the strings in the web hook header.

Here are the docs for securing the web hooks for Github. https://docs.github.com/en/developers/webhooks-and-events/webhooks/securing-your-webhooks

greenpau commented 2 years ago

@joeworkman , please test it with latest https://github.com/greenpau/caddy-git/releases/tag/v1.0.5