search

greenpau / cni-plugins

CNI Plugins compatible with nftables
Apache License 2.0
48 stars 13 forks source link

bind port mappings to HostIP, if specified #25

Closed stapelberg closed 5 months ago

stapelberg commented 5 months ago

When using podman run -p 10.25.0.1:8443:8443 before this commit, port 8443 would be reachable on all interfaces, as if one used podman run -p 8443:8443.

This is obviously not great for security — I’m using podman on an internet router with multiple network interfaces and really want to have my container ports reachable only internally, not also on the public internet :)

greenpau commented 5 months ago

@stapelberg , do you want to take on the ownership of this repo? If you do, I will transfer it to you. Nowadays, I am far away from nft and wondering whether the people using it be better off with a maintainer like you.

stapelberg commented 5 months ago

Hey @greenpau! I’m stretched pretty thin myself, but certainly closer to nft and an active user of this project. Feel free to grant me owner permission on the repository and I can help with some best-effort maintenance :)

greenpau commented 5 months ago

@stapelberg, this is great! Thank so much! I sent you an invite to join. I am doing it for the first time. Did not see the option to grant you the owner directly. My guess is that after you accept. I set the owner level.

stapelberg commented 5 months ago

Accepted. Let me know how you want to proceed with this PR: Do you want to merge it? Would you prefer if I did?

greenpau commented 5 months ago

@stapelberg , please see if you can do it with your current permissions. There is no way for me to add ownership level through this interface.

greenpau commented 5 months ago

Thank you, @stapelberg!