search

greenpau / ovn_exporter

Prometheus Exporter for Open Virtual Network (OVN)
Apache License 2.0
21 stars 18 forks source link

Split exporter initialization into two steps #3

Closed pawelmarkowski closed 3 years ago

pawelmarkowski commented 3 years ago

Resolves: #2 .

  1. Initialize new Exporter
  2. Initialize Client in NewExporter
  3. Update Client struct fields using flags (command line attributes)
  4. Create Client connection using updated fields values.

Those steps shall fix an issue.

greenpau commented 3 years ago

@pawelmarkowski , thank you for the PR. LGTM 👍

Ready to merge?

pawelmarkowski commented 3 years ago

yes

greenpau commented 3 years ago

@pawelmarkowski , merged!