search

greenpau / ovs_exporter

Prometheus Exporter for Open Virtual Switch (OVS)
Apache License 2.0
25 stars 17 forks source link

Add binary release #2

Closed berendt closed 2 years ago

berendt commented 3 years ago

It would make sense to have the binary artifact directly in the release.

greenpau commented 3 years ago

@berendt , I am adding Github Actions and will build an artifact there.

berendt commented 3 years ago

@greenpau Great. Thank you for the quick implementation.

greenpau commented 3 years ago

@berendt , also, wouldn't it be easier to do the following?

go get -u github.com/greenpau/ovs_exporter/cmd/ovs_exporter
berendt commented 3 years ago

@greenpau I would like to use the binary in Kolla for a new image. There we pull the tarballs of the exporters by curl from Github. From our point of view it would be good if we could make it uniform there.

https://github.com/openstack/kolla/blob/master/docker/prometheus/prometheus-memcached-exporter/Dockerfile.j2#L13

Edit: https://review.opendev.org/c/openstack/kolla/+/764995

greenpau commented 3 years ago

From our point of view it would be good if we could make it uniform there.

@berendt , understood. Will get the binary done. Also, I wrote this exporter a while ago. Unfortunately, I switched a job to one where I do not use my cloud skills. Does the exporter still work? :-) ... btw, if you hear people hiring in NYC, please ping me.

greenpau commented 3 years ago

@berendt , all done.

image

Please test and close the issue if all is well.

greenpau commented 3 years ago

@berendt , I just checked and the exporter is working.

greenpau commented 3 years ago

@berendt , i improved tests. Please see Run stage of the latest Github Actions run. It has the metrics the exporter exports.

berendt commented 3 years ago

Thank you. Can you please add arm64 as 2nd architecture?

I'm testing the image today and then giving feedback again.

greenpau commented 3 years ago

Thank you. Can you please add arm64 as 2nd architecture?

@berendt , done.

image