greenpeace / planet4-child-theme-australiapacific

Greenpeace Planet 4 Australia Pacific Theme
GNU General Public License v3.0
2 stars 1 forks source link

Adding script for Marker.io #33

Closed karabishopgreenpeace closed 10 months ago

karabishopgreenpeace commented 11 months ago

Visual feedback tool

Pull Request Overview

Marker.io is a visual feedback tool see https://www.notion.so/greenpeaceaustraliapacific/User-Feedback-Tool-Comparison-4e7a550c208142d0b0ab3e54807be4d9

πŸ“· Screenshots

NA

🀨 Any Issues or Questions?

NA

🏁 PR Checklist

Reviewer checklist:

Contributor checklist:

karabishopgreenpeace commented 10 months ago

It was working perfectly the other day )-: (tested on Hubspot). It was configured to need ?feedback in the url, but I've changed it to public now.

But now I'm getting an error.

Screenshot 2023-12-20 at 11 35 31β€―am

I have been testing it on this page: https://www.greenpeace.org.au/donate/test-header

Screenshot 2023-12-20 at 11 35 24β€―am

The feedback has been flowing into this Notion Board.

Can you think of anything that might have broken it? Did you do anything in Cloudflare or anything??

The Marker.io logins are in Bitwarden if you want to check it out.

ShoryuDZ commented 10 months ago

@karabishopgreenpeace I gave Marker.Io a test through the link you gave me (the hubspot page) - looks to be working well and I can see my feedback flow though to the Notion page as set up. Great to see Marker.io working!

Now, I need to see this work on our P4 site - either in development or locally, and once that works consistently (for multiple people on different devices) - I'll be happy to approve.

karabishopgreenpeace commented 10 months ago

@ShoryuDZ we've added http://www.planet4.test/ as a domain to Marker.io, so would you mind trying on your local environment? I'm having issues getting mine running.

Alternatively, I'm thinking it might be better to add this script to Tag Manager. Would that be better?

Screenshot 2024-01-09 at 11 11 17β€―am
karabishopgreenpeace commented 10 months ago

Trial period has run out. I'll need to get Vic to upgrade the Marker.io account. Will let you know once it's done.

karabishopgreenpeace commented 10 months ago

@ShoryuDZ I've added the script via Tag Manager (Working fine if you want to have a look)

https://www-dev.greenpeace.org/australiapacific/

I think it makes sense to have all tool scripts to be added via tag manager rather than on the actual site. Let me know if you disagree.

techieshark commented 10 months ago

@karabishopgreenpeace Congrats on getting this working Kara!

[And just a sidenote, let's keep thinking of ways to improve our review process here… e.g. one idea is getting code review sessions on the calendar between you and @ShoryuDZ - since we are all in the same timezone we might as well make the most of our ability to work side by side on things.]

it makes sense to have all tool scripts to be added via tag manager

In a nutshell I think Google Tag Manager will work OK when:

For this item, it does feel like it sort-of fits into the "marketing / research" category, so I'm OK with it being added via GTM.

However, since javascript code can cause problems on pages regardless of if they're added via the theme or via GTM, please do keep us looped in if/when you are adding scripts via GTM. Thanks! :)