Remove spacing above footer

[ashleytowner]

Pull Request Overview

This adds a negative margin to the top of the footer, so that it overlaps with content, as required in this ticket

Ensure that, on all screen sizes, the footer always overlaps with the content above it

There's a slightly different negative margin for a couple of different screen sizes, these are the minimum numbers I found were necessary.

📷 Screenshots

Of course, this also results in the situation where if there's text at the bottom of a page, then the footer will still overlap it, there's not really an automatic way to distinguish between whether the element beforehand contains something we do or don't want overlapped. Content creators will have to be aware of this when laying out their content, and ensure that they put an image or some content that can be overlapped at the bottom of the page.

🤨 Any Issues or Questions?

@karabishopgreenpeace do we still want to go ahead with this given it can overlap real content?

🏁 PR Checklist

Reviewer checklist:

• [ ] ✨ This PR includes new user-facing feature and/or settings
• [ ] 📝 Documentation for new features/settings are in PR description (to go to wiki or Coral docs)

Contributor checklist:

• [ ] Reference a GitHub issue, Jira ticket, or Notion card in the description 💯
• [ ] 📝 Update the CHANGELOG.md (Put under [Unreleased]). Include link to this PR.
• [ ] 📝 Add JSDoc code documentation
• [ ] 🏷 Add flow types. (If needed.)
• [ ] ✅ Add unit tests (*.test.js) and/or Cypress Tests.
• [ ] 📖 Create Storybook stories. (For any applicable Components.)
• [ ] 📸 Update snapshots. Run yarn test:watch, press 'a' for "all tests", and "u" to update snaps if needed.
• [ ] Run tests (yarn test and yarn flow) and clean up any errors 🚀
• [x] Select 1-2 Reviewers
• [x] Feel good about yourself, you're doing great! 🥳

[ashleytowner]

I'd like a technical review from @techieshark, but I don't want to merge this before @karabishopgreenpeace has agreed that this is the behaviour we want.

[karabishopgreenpeace]

@ashleytowner hold off on this. The solution needs to have a general padding on all pages so the content is visible. Then a negative margin on specific pages that need to overlap. At the moment there is a .footer-cta class added to these specific blocks. Sorry, I don't have time at the moment to work on this, so for the time being, I think we just leave it as is.

[ashleytowner]

Closed, as it didn't meet the requirements