New features todo - Githubissues

greenpeace / planet4-docker-compose-dev

Planet4 docker compose dev environment

1 stars 0 forks source link

New features todo #1

Open kirdia opened 6 years ago

kirdia commented 6 years ago

[ ] Add nodejs, npm in planet4 container and install stylelint & eslint
[ ] Change test domain
[ ] Enable ssl in nginx container
[ ] File watchers for scss/js compiling
[ ] ~~Preserve uploads/images. Investigate why attachments are erased from db after planet4 container restart.~~ (because user dev is deleted/recreated)

comzeradd commented 6 years ago

I also do change composer.json on planet4-base to pull in the develop branch of both master-theme and plugins.

"greenpeace/planet4-master-theme" : "dev-develop",
"greenpeace/planet4-plugin-blocks" : "dev-develop",

Maybe there is a way to provision that change from the docker script, since it makes more sense to work over the develop branch than a specific release.

koyan commented 6 years ago

There is no need to do that. Please read the instructions at: https://github.com/greenpeace/planet4-base about composer-merge that is already used. If you merge the correct file before implementation (and before composer-install and composer-update) as the instructions say, you don't need to manually change anything:

https://github.com/greenpeace/planet4-base/blob/master/app/planet-4-151612/develop/composer.json

27Bslash6 commented 6 years ago

Any reason to re-implement these here, when domain changing, SSL is already enabled on https://github.com/greenpeace/planet4-docker-compose ?

27Bslash6 commented 6 years ago

Am glad to hear you're thinking about using gulp/grunt for automatic asset management though, that's a big +1. It would be very simple to include this functionality in a child or, preferably, sidecar container of https://github.com/greenpeace/planet4-docker/tree/master/src/planet-4-151612/wordpress if required.