greenpeace / planet4

Built on top of Wordpress tech, Greenpeace Planet 4 powers digital platforms to engage with millions and win campaigns around the world.
https://planet4.greenpeace.org
Creative Commons Attribution Share Alike 4.0 International
66 stars 27 forks source link

PLANET-5538 Use h1 for the Search Results title #104

Closed planet-4 closed 3 years ago

planet-4 commented 3 years ago

It's a good practice for pages to have the top headline as h1. In the Search Page that's the "(n) results for ''. eg. https://www.greenpeace.org/international/?s=climate&orderby=_score

Tasks

Reporter: nroussos
Sections: 

Potentially affected repositories: planet4-master-theme

oekeur commented 3 years ago

That would give strange results SEO wise I guess, right? How about: <h1>Search for [term]</h1> <h2>x results found<h2> ?

emmarise commented 3 years ago

Our team changed it just now, I think @powersaudrey25 has already pull request.

comzeradd commented 3 years ago

Fixed at https://github.com/greenpeace/planet4-master-theme/commit/4186372c4c5caddebd393a4bacc3a37321929e6a